Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVG support to FastDL #2298

Merged
merged 2 commits into from Apr 22, 2019
Merged

Add SVG support to FastDL #2298

merged 2 commits into from Apr 22, 2019

Conversation

borzaka
Copy link
Contributor

@borzaka borzaka commented Apr 15, 2019 •
edited

Description

CS:GO with Panorama now supports SVG custom logos, which are displayed in more places than a PNG logo.

Bonus:
Extend materials with .png support.

Fixes #2297

Edit: unfortunately it's not working for logos out-of-the-box, because the FastDL directory must be the same as in the CS:GO directory structure, so you have to manually create the folders and copy your logo files there.

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • New Server (new server added)
  • Refactor (restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • This pull request uses the develop branch as its base
  • I have performed a self-review of my own code
  • I have squashed commits
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation if required

@borzaka
Add SVG support to FastDL
72895e8 
CS:GO with Panorama now supports SVG custom logos, which are displayed in more places than a PNG logo.
Fixes GameServerManagers#2297
@borzaka
Add PNG és SVG to materials extentions array
f8d25f8 
Panorama now uses materials/panorama/images/tournaments/teams folder to look for custom team logos, which can be .png and .svg
@dgibbs64
Copy link
Member

@borzaka Please can you provide your github email address so I can do a squash merge. Thanks

Co-authored-by:

@dgibbs64 dgibbs64 merged commit 24f0900 into GameServerManagers:develop Apr 22, 2019
@borzaka borzaka deleted the patch-1 branch April 22, 2019 21:06
@dgibbs64 dgibbs64 added this to the next release milestone Apr 22, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Apr 22, 2019
Merged
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
game: Counter-Strike: Global Offensive type: feature request New feature or request
Projects
None yet
Milestone
190422
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borzaka @dgibbs64